Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for MSVC 1940 & 1941, CMake 3.30, Github Actions Node16 #1225

Merged
merged 14 commits into from
Sep 4, 2024
Merged

Fixes for MSVC 1940 & 1941, CMake 3.30, Github Actions Node16 #1225

merged 14 commits into from
Sep 4, 2024

Conversation

ptheywood
Copy link
Member

@ptheywood ptheywood commented Aug 22, 2024 •
edited
Loading

Fixes a number of issues caused by changes in external tools

  • Short term fix for CMake 3.30 deprecating current use of FetchContent_Populate. This will need a more permanent fix in the future, see CMake 3.30 deprecates FetchContent_Populate #1223.
  • MSVC 1940 with CUDA < 12.3 requires CUDAFLAGS=-allow-unsupported-compilers plus CMake >= 3.29.4.
  • MSVC 1941 requires CUDA >= 12.4 due to a static assertion change in the STL
    • A warning is emitted to potentially effected users
    • CI is ammeded so CUDA <= 12.3 uses VS2019
  • Applies a short term workaround to CI for a June 2024 Github Actions change which removes support for using actions/checkout etc in Manylinux2014 containers.
  • Updates CI to include CUDA 12.6 builds
  • Updates the visualisation repo hash, as similar fixes are required in the separate repository.

@ptheywood
CMake: Short term fix for policy CMP0169
9e528a4 
Sets policy CMP0169 to OLD to prevent dev warnings related to FetchContent_Populate(<name>).

This needs fixing propperly for longer term support, see #1223
@ptheywood
CMake: Warn about MSVC >= 1940 and CUDA <= 12.3 incompatibility with …
c1ccf8b 
…suggestion
@ptheywood
CI: MSVC 1940 + CUDA <= 12.3 fix in Windows.yml CI via CUDAFLAGS
638f556
@ptheywood
CI: regular CI matrix update to include CUDA 12.6
7f98d72 
The regular linux and windows workflows now include:

+ Latest CUDA (12.6)
  + release no vis
  + release vis
  + beltsoff no vis
  + beltsoff vis
+ CUDA 12.0
  + release no vis
+ CUDA 11.8
  + release no vis
  + release vis
+ CUDA 11.0
  + release no vis

This is a compromise to cover a wider set of configurations, without increasing CI demand too much
@ptheywood
CI: Temporary workaround for manylinux2014 containers glibc error
85ef8ae 
Github switched from Node 16 to Node 20 for Github actions runners on 2024-06-03.
This is incompatble with older linux distributions, including centos7.

This sets an env var which will alllow the use of node 16, but this will stop working at some point when github fully remove node 16.

This is separate but related to #1224
@ptheywood
Examples: Fix missing include for FLT_MAX in circles examples using C…
dfcfb72 
…UDA 12.5

Closes #1216
@ptheywood
CI: Update Windows-Tests manual CI with additional MSVC 1940 fix and …
5957ea1 
…CUDA 12.6
@ptheywood
CI: Fix comments in Ubuntu.yml
19def83
@ptheywood
CI: Draft release thoroguh ubuntu build CUDA update and comment fixes
c0cac32
@ptheywood
CI: Draft Release MSVC 1940 fix + thorough build cuda tweak
5a0a77a
@ptheywood
CI: Draft release Manylinux2014 Node version fix
442993b
@ptheywood
CMake: Update visualisation repo hash to include MSVC, CMake & CI fixes
84388eb
@ptheywood ptheywood force-pushed the msvc-1940-cuda-12.3-warning-and-ci branch from bfca009 to 84388eb Compare August 29, 2024 13:24
@ptheywood ptheywood marked this pull request as ready for review August 30, 2024 16:52
@ptheywood ptheywood requested a review from Robadob August 30, 2024 16:52
@ptheywood ptheywood changed the title Fixes for MSVC 1940, CMake 3.30, Github Actions Node16 Fixes for MSVC 1940 & 1941, CMake 3.30, Github Actions Node16 Aug 30, 2024
@ptheywood ptheywood mentioned this pull request Sep 4, 2024
Closed
@ptheywood ptheywood merged commit 42786c5 into master Sep 4, 2024
75 checks passed
@ptheywood ptheywood deleted the msvc-1940-cuda-12.3-warning-and-ci branch September 4, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Robadob Robadob Robadob approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FLT_MAX undefined in CUDA 12.5 for the circles examples Windows CI failures
2 participants
@ptheywood @Robadob